v5.48 - Feedback

Status
Not open for further replies.

Winny57

Active member
What kind of trouble do you have while transferring data? The only issue that have existed for a long time is that when transferring data from a specific level of a multilevel dictionary, the level is sometimes lost and the whole dictionary is transferred.
As in my macro the transfer of the Key variable to the action block variable is not done.

I don't know if this comes from my side or from a MacroDroid problem.
 

MacroDroidDev

Administrator
Staff member
Is it me or the definition of variables between action blocks and macro variables are problematic?

I am working on an API for football results and rankings the problem is that I have trouble transferring data from the Key variable to the action block variable.

Here is my draft
@Winny57 It looks like somehow the input variable is missing on the ApiFoot action block. If you add it back I think it should work correctly.
 

Winny57

Active member
ApiFoot action block does not need input variable whereas apifoot2 needs key variable but it does not add
 

Attachments

  • Screenshot_20241016-103659.png
    Screenshot_20241016-103659.png
    217.2 KB · Views: 7
  • Screenshot_20241016-103649.png
    Screenshot_20241016-103649.png
    171.9 KB · Views: 7

MacroDroidDev

Administrator
Staff member
Ok, it looks like it was previously set to pass it to ApiFoot but you changed it and the old input variable info is still hanging around in the action info (does no harm but a bit misleading!).

I just done a simple test of adding a pop up messaeg to Api foot2 to display the passed in variable value and it was set correcly for me. Do you have some clear evidence that the value is not being passed through correctly?
 

Endercraft

Moderator
Since action blocks have been added I've had this problem where input/output variables get deconfigured and aren't passed. That could be the reason.
 

Winny57

Active member
I tried to create a new macro and transfer a variable to a block but it doesn't work

I will have to extract the contents of the blocks to leave them in the macro and delete the blocks without using my blocks
 

Attachments

  • Polish_20241016_105549863.png
    Polish_20241016_105549863.png
    135.4 KB · Views: 6
  • Polish_20241016_105628129.png
    Polish_20241016_105628129.png
    171 KB · Views: 6

apollo316

New member
Fixed issue where fold state trigger would fire incorrectly when the app is swiped away in the task switcher.
Confirmed fixed. Swiping MD closed from app switcher and a quick face up gesture from face down no longer triggers the fold state. Thank you!
 

Wifi4680

New member
Hi, I'm using a Xiaomi 14T with Android 14, and I've noticed that with a locationupdate triggered by MacroDroid, the camera recording stops and YouTube switches to picture-in-picture mode.
 

GamBIT

Active member
'Macro list screen now shows an animated indicator when a macro is currently running.'
but... it can remain to show that dots waving while the macro has been stopped many time ago.
and if you tap on the macro and get back - if doesn't show the dots already.

and one more thing related:
the trigger 'Macro Finished' and the constraint 'Macro Not Running' fail to work right for the cases when a screen orientation has been changed and when in the macro is a command 'Cancel Macro Actions'. If Cancel Macro Actions is executed, the trigger still sees the macro as 'running', and the constraint too. If the screen is rotated while macro is running, the trigger fires as if the macro was closed and opened again, while the macro is still running with no break.
 

GamBIT

Active member
In the command 'Animation Overlay' is often lost the value 'loop count' if the *mdr is saved and opened again. And when updating the MD version. It results in the faults in the system log page. MD does forget if the option 'fixed number of seconds' is selected and how many seconds to animate. If you then open the command, the field 'seconds' or 'loop count' is empty.
 
Last edited:

GamBIT

Active member
In the Selection Dialog the new ability to move the items still works not perfect. If to create a new item, do some formatting to it and move it upwards and save, then usually the last old item of the dialog would be spoiled.
 
The HTTP request trigger often does not fire when the phone is in sleep mode, and it only triggers when the phone is active and in use. ver5.48.11
 

Attachments

  • Screenshot_2024-10-29-10-22-24-197_com.arlosoft.macrodroid.jpg
    Screenshot_2024-10-29-10-22-24-197_com.arlosoft.macrodroid.jpg
    512.7 KB · Views: 5

GamBIT

Active member
@GamBIT Please submit bug reports with exact details on how to recreate each issue you have described.
Hello.
All the described problems may be easily recreated if doing the things I've described.
Also I have noticed the animated indicator relays on the same detection of finished macro as the trigger and constraint. And while MD doesn't see now that finishing if a command 'Cancel Macro Actions(this macro)' is executed inside the macro, then many problems occur. Trigger, constraint, animated indicator.. Also it thinks that the macro was launched again if the screen orientation has been changed while the macro was running. It works always such a way.
It's funny that if the animated indicator shows that a stopped macro is still running, then it is enough to switch to main page and switch back to the macro page, just the indicator shows the macro isn't running now.
 

MacroDroidDev

Administrator
Staff member
@GamBIT If they were that easy to reproduce then of course I wouldn't ask this. They may be easy for you to reproduce on your device but that doesn't mean they are easy for me to reproduce.

For example this description does not in anyway help me to reproduce the issue you are reporting.

'Macro list screen now shows an animated indicator when a macro is currently running.'
but... it can remain to show that dots waving while the macro has been stopped many time ago.
and if you tap on the macro and get back - if doesn't show the dots already.

Ok, so it can remain in some scenario(s) but that is all I know.... The reality is there are many complexities in the implementation and the issue is very likely to be related to a specific macro configuration.

I already get more support and bug reports than I can realistically deal with, so I have to focus on things that are clear and easily actionable. I could spend hours trying to recreate problems and probably I will recreate them in the end but at the end of that day I have 20 more bug reports and support requests to deal with and I will never get any actual development work done.
 

GamBIT

Active member
@GamBIT If they were that easy to reproduce then of course I wouldn't ask this. They may be easy for you to reproduce on your device but that doesn't mean they are easy for me to reproduce.

For example this description does not in anyway help me to reproduce the issue you are reporting.

'Macro list screen now shows an animated indicator when a macro is currently running.'
but... it can remain to show that dots waving while the macro has been stopped many time ago.
and if you tap on the macro and get back - if doesn't show the dots already.

Ok, so it can remain in some scenario(s) but that is all I know.... The reality is there are many complexities in the implementation and the issue is very likely to be related to a specific macro configuration.

I already get more support and bug reports than I can realistically deal with, so I have to focus on things that are clear and easily actionable. I could spend hours trying to recreate problems and probably I will recreate them in the end but at the end of that day I have 20 more bug reports and support requests to deal with and I will never get any actual development work done.
Hello! I understand but please, create a simple testing macro with the Empty Trigger with only 2 actions:

1. wait 5 seconds
2. Cancel Macro Actions [This Macro]

And that's all. It is easier to create just in 10 seconds then downloading.
Just run the 'Test action command' for this macro at the Macros page and You'll see the dots waving endlessly. But they would stop it after 5 seconds, right?

I dont think this behavior is made purposely since if the macro isn't running - where is no need to show that dots. And pay attention - if you switch to the Home page and return - the dots will disappear themselves. I think this case is a key to understand why there are the other described relative problems - the command 'Cancel Macro Actions'. MD cannot understand now that this command is the same with the normal end of the macro's flow. And is thinking that macro has not come to its end - and guesses the 'running' status. But when we leave the Marcos page and return - MD reloads smth and sees that the macro has been ended. IMHO.

Screen orientation, as I was told now, is a problem not for only MD. It feels like a real relaunching a program. But I think MD would understand that if a macro is still running while orientation has been changed, the trigger Macro Finished would not fire in ideal. (if one macro is watching for the second macro and using the Macro Finished trigger to do some things if the second macro has been ended, it would not fire if the screen orientation has been changed via the MD command inside the second macro. At that case the proper constraint sees that the second macro is not running while it is actually running. So we cannot simply check if the macro is running or not at this case. Now I have to use a crutch - I do disable from the second macro the Macro Finished trigger inside the first macro, do change orientation and enable the trigger back. Else it would fire if the screen orientation mode is changed.
 
Last edited:

Jacob L

Moderator (Lawsonator)
I don't even see any animation even with animations enabled from accessibility settings or developer options!
 

Dm114

Well-known member
Hello! I understand but please, create a simple testing macro with the Empty Trigger with only 2 actions:

1. wait 5 seconds
2. Cancel Macro Actions [This Macro]

And that's all. It is easier to create just in 10 seconds then downloading.
Just run the 'Test action command' for this macro at the Macros page and You'll see the dots waving endlessly. But they would stop it after 5 seconds, right?

I dont think this behavior is made purposely since if the macro isn't running - where is no need to show that dots. And pay attention - if you switch to the Home page and return - the dots will disappear themselves. I think this case is a key to understand why there are the other described relative problems - the command 'Cancel Macro Actions'. MD cannot understand now that this command is the same with the normal end of the macro's flow. And is thinking that macro has not come to its end - and guesses the 'running' status. But when we leave the Marcos page and return - MD reloads smth and sees that the macro has been ended. IMHO.

Screen orientation, as I was told now, is a problem not for only MD. It feels like a real relaunching a program. But I think MD would understand that if a macro is still running while orientation has been changed, the trigger Macro Finished would not fire in ideal. (if one macro is watching for the second macro and using the Macro Finished trigger to do some things if the second macro has been ended, it would not fire if the screen orientation has been changed via the MD command inside the second macro. At that case the proper constraint sees that the second macro is not running while it is actually running. So we cannot simply check if the macro is running or not at this case. Now I have to use a crutch - I do disable from the second macro the Macro Finished trigger inside the first macro, do change orientation and enable the trigger back. Else it would fire if the screen orientation mode is changed.
You should do what Dev told you otherwise he won't have time to spend in trying to recreate from scratch your problem or reading tens and tens of lines of explanations.

It's a personal advice...
 

MacroDroidDev

Administrator
Staff member
Hello! I understand but please, create a simple testing macro with the Empty Trigger with only 2 actions:

1. wait 5 seconds
2. Cancel Macro Actions [This Macro]

And that's all. It is easier to create just in 10 seconds then downloading.
Just run the 'Test action command' for this macro at the Macros page and You'll see the dots waving endlessly. But they would stop it after 5 seconds, right?

I dont think this behavior is made purposely since if the macro isn't running - where is no need to show that dots. And pay attention - if you switch to the Home page and return - the dots will disappear themselves. I think this case is a key to understand why there are the other described relative problems - the command 'Cancel Macro Actions'. MD cannot understand now that this command is the same with the normal end of the macro's flow. And is thinking that macro has not come to its end - and guesses the 'running' status. But when we leave the Marcos page and return - MD reloads smth and sees that the macro has been ended. IMHO.

Screen orientation, as I was told now, is a problem not for only MD. It feels like a real relaunching a program. But I think MD would understand that if a macro is still running while orientation has been changed, the trigger Macro Finished would not fire in ideal. (if one macro is watching for the second macro and using the Macro Finished trigger to do some things if the second macro has been ended, it would not fire if the screen orientation has been changed via the MD command inside the second macro. At that case the proper constraint sees that the second macro is not running while it is actually running. So we cannot simply check if the macro is running or not at this case. Now I have to use a crutch - I do disable from the second macro the Macro Finished trigger inside the first macro, do change orientation and enable the trigger back. Else it would fire if the screen orientation mode is changed.

Thanks, so the issue is the cancel macro actions doesn't stop this animation that's all I needed to know. This was not obvious to me because I have previously tested and ensure it did, but I obviously broke something in later changes. Now I know this it should be an easy fix for a future update.
 
Status
Not open for further replies.
Top